Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds caching proxy example using HOMEBREW_ARTIFACT_DOMAIN #19131

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

colindean
Copy link
Contributor

I brought this up several months ago and got a solution working that's been running on my work machine since early September without failure.

Possible additions:

  • A statement expressing any limitations on supporting this configuration
  • A statement, perhaps in a comment, limiting the tip to the idea and that it should not be an ever-growing HOWTO for every artifact hosting system.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I brought this up several months ago and got a solution working that's been running on my work machine since early September without failure.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @colindean!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 22, 2025
Merged via the queue into Homebrew:master with commit adb044c Jan 22, 2025
28 checks passed
@colindean colindean deleted the patch-5 branch January 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants