Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode: expect 8.3.3/recognise 9.0 on 10.13 #2736

Merged
merged 5 commits into from
Jun 6, 2017
Merged

xcode: expect 8.3.3/recognise 9.0 on 10.13 #2736

merged 5 commits into from
Jun 6, 2017

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Jun 6, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Wee follow up to #2732.

@ilovezfs ilovezfs added the 10.13 label Jun 6, 2017
@mistydemeo
Copy link
Member

I'll take your word on the versions! Haven't gotten a VM going yet.

@mistydemeo mistydemeo merged commit 576eb74 into Homebrew:master Jun 6, 2017
@MikeMcQuaid
Copy link
Member

@mistydemeo @DomT4 FYI we need to wait on bumping the Xcode version until we've updated our CI boxes. Currently all builds there are failing as a result.

@DomT4
Copy link
Member Author

DomT4 commented Jun 7, 2017

@MikeMcQuaid Sorry, I meant to leave a note that someone would need to sort that side of things out.

Thanks for merging @mistydemeo ❤️. I couldn't get APFS working inside VMware (useful 30 day free trial allows me to determine how much it'd trash my own system to update, heh) but otherwise it wasn't a complete nightmare. If I upgraded from Sierra to High Sierra (which I'm still not convinced isn't a temporary "haha got ya" name) and enabled APFS it refused to boot.

@DomT4 DomT4 deleted the xcodes branch June 7, 2017 03:00
@Homebrew Homebrew deleted a comment from kylebrowning Jun 17, 2017
@jmoody
Copy link

jmoody commented Jun 23, 2017

Is it too soon to require Xcode 9.0 for High Sierra?

For Sierra, Xcode 8.0 was the only option, but for High Sierra, Xcode 8.3.3 might be a better candidate for the minimum Xcode until 9.0 is out of beta (or the early betas at least).

I am fishing for feedback before I create an issue or pull request.

Thanks for brew - I depend on this tool. Keep up the good work.

@ilovezfs
Copy link
Contributor

Is it too soon to require Xcode 9.0 for High Sierra?

No, on balance the problems are usually the reverse where we get issues filed that only occur if you're using the older Xcode.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants