sandbox: sandbox all taps by default. #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll hold off merging this until we plan on shipping 1.3.0. |
ilovezfs
approved these changes
Jul 14, 2017
We've been doing this in `brew test-bot`, for our CI and for homebrew/core long enough that this is a reasonable default that provides more protection to our users of non-homebrew/core taps.
JCount
approved these changes
Jul 15, 2017
apjanke
approved these changes
Jul 19, 2017
chapskev
added a commit
to chapskev/msphpsql
that referenced
this pull request
Sep 13, 2017
I have determined that the install failure is due to another "security feature" recently introduced into Homebrew --- as of 1.3.0 --- which runs all installers in a restricted sandbox environment: Homebrew/brew#2898 However, you can still disable that with an option, and it will register the driver in odbcinst.ini correctly without having to perform the manual workaround above: microsoft/homebrew-mssql-release#1 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been doing this in
brew test-bot, for our CI and for homebrew/core long enough that this is a reasonable default that provides more protection to our users of non-homebrew/core taps.