audit: Port audit_options rules for new formulae to rubocop and add test #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
requested changes
Jul 15, 2017
|
|
||
| module NewFormulaAudit | ||
| class Options < FormulaCop | ||
| MSG = "New Formula should not use `deprecated_option`".freeze |
There was a problem hiding this comment.
Newline after MSG (and in general can you go and fix that up for any other occurrences in this or other cops?)
There was a problem hiding this comment.
(feel free to do all of them in this PR)
There was a problem hiding this comment.
I checked and found no recurrence in other cops.
GauthamGoli
force-pushed
the
audit_option_rubocop_3
branch
from
32510b6 to
a8f1b02
Compare
MikeMcQuaid
approved these changes
Jul 15, 2017
|
Thanks again @GauthamGoli! |
MikeMcQuaid
reviewed
Jul 15, 2017
| @@ -27,6 +27,9 @@ FormulaAudit/Options: | |||
| FormulaAuditStrict/Options: | |||
| Enabled: true | |||
|
|
|||
| NewFormulaAudit/Options: | |||
| Enabled: true | |||
There was a problem hiding this comment.
@GauthamGoli I've disabled this in 207ffd6 as it was activating for every formula every time.
There was a problem hiding this comment.
Looking into it now.
4 tasks
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?#569
Continuation of #2879 and #2901 . This PR finishes porting of
audit_optionsmethod completely fromaudit.rbto rubocop.This also introduces a new department of cops
NewFormulaAuditas the name suggests, cops which execute when--new-formulaflag is passed to audit.