Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update guidelines for duplicates #2939

Merged
merged 3 commits into from
Jul 25, 2017
Merged

docs: update guidelines for duplicates #2939

merged 3 commits into from
Jul 25, 2017

Conversation

EricFromCanada
Copy link
Member

As per #2873, duplicate and versioned formulae are fine if done right.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [N/A] Have you written new tests for your changes? Here's an example.
  • [N/A] Have you successfully run brew tests with your changes locally?

@EricFromCanada
docs: update guidelines for duplicates
b4127ee 
As per Homebrew#2873, duplicate and versioned formulae are fine if done right.
MikeMcQuaid
MikeMcQuaid requested changes Jul 25, 2017
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit but great work as usual here @EricFromCanada!

docs/brew-tap.md
@@ -11,7 +11,7 @@ but the command isn't limited to any one location.

```sh
$ brew tap
homebrew/dupes
homebrew/core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe homebrew/bundle as homebrew/core is tapped by default?

Copy link
Member Author

@EricFromCanada EricFromCanada Jul 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My logic was to mirror its actual output, but ¯\(ツ)/¯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricFromCanada I'm an idiot. Changed it back. Sorry!!

@MikeMcQuaid MikeMcQuaid merged commit 88b762f into Homebrew:master Jul 25, 2017
@MikeMcQuaid
Copy link
Member

Thanks again @EricFromCanada and apologies for my earlier misreading.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricFromCanada @MikeMcQuaid