Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS: use RbConfig instead of RUBY_PLATFORM #2951

Merged
merged 1 commit into from
Jul 27, 2017
Merged

OS: use RbConfig instead of RUBY_PLATFORM #2951

merged 1 commit into from
Jul 27, 2017

Conversation

bfontaine
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

RUBY_PLATFORM is always "java" when running JRuby, no matter what the underlying platform is. Using RbConfig fixes that (see pry/pry#386).

`RUBY_PLATFORM` is always `"java"` when running JRuby, no matter what is
the underlying platform.

See also pry/pry#386.
@MikeMcQuaid MikeMcQuaid merged commit 0b78a7f into Homebrew:master Jul 27, 2017
@MikeMcQuaid
Copy link
Member

Thanks @bfontaine!

@bfontaine bfontaine deleted the s/ruby_platform/rbconfig branch July 27, 2017 14:40
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants