Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the five executables in a list #2963

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Put the five executables in a list #2963

merged 2 commits into from
Aug 1, 2017

Conversation

cclauss
Copy link

@cclauss cclauss commented Jul 29, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@cclauss cclauss mentioned this pull request Jul 29, 2017
Closed
5 tasks
MikeMcQuaid
MikeMcQuaid requested changes Jul 30, 2017
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please push changes to this PR rather than opening a new one, thanks.

docs/Homebrew-and-Python.md Outdated
@@ -9,7 +9,12 @@ Homebrew provides formulae to brew a more up-to-date Python 2.7.x and 3.x.
**Important:** If you choose to install a Python which isn't either of these two (system Python or brewed Python), the Homebrew team can only provide limited support.

## Python 2.x or Python 3.x
Homebrew provides a formula for Python 2.7.x and one for Python 3.x. They don't conflict, so they can both be installed. The executable `python2` will always point to the 2.x and `python3` to the 3.x version. The executable `python` will always point to the macOS system Python.
Homebrew provides one formula for Python 2.7.x and another for Python 3.x. The executables are organized as follows so that Python 2 and Python 3 can both be installed without conflict:
* `python` by default points to the macOS system Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python points to the macOS system Python (with no manual PATH modification)

docs/Homebrew-and-Python.md Outdated
Homebrew provides a formula for Python 2.7.x and one for Python 3.x. They don't conflict, so they can both be installed. The executable `python2` will always point to the 2.x and `python3` to the 3.x version. The executable `python` will always point to the macOS system Python.
Homebrew provides one formula for Python 2.7.x and another for Python 3.x. The executables are organized as follows so that Python 2 and Python 3 can both be installed without conflict:
* `python` by default points to the macOS system Python
* `python2` will point to the brew-installed Python 2.7.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2 points to Homebrew's Python 2.7.X (if installed)

docs/Homebrew-and-Python.md Outdated
Homebrew provides one formula for Python 2.7.x and another for Python 3.x. The executables are organized as follows so that Python 2 and Python 3 can both be installed without conflict:
* `python` by default points to the macOS system Python
* `python2` will point to the brew-installed Python 2.7.x
* `python3` will point to the brew-installed Python 3.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3 points to Homebrew's Python 3.X (if installed)

docs/Homebrew-and-Python.md Outdated
* `python` by default points to the macOS system Python
* `python2` will point to the brew-installed Python 2.7.x
* `python3` will point to the brew-installed Python 3.x
* `pip2` will point to the pip associated with the brew-installed Python 2.7.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip2 points to Homebrew's Python 2.7.X's pip (if installed)

docs/Homebrew-and-Python.md Outdated
* `python2` will point to the brew-installed Python 2.7.x
* `python3` will point to the brew-installed Python 3.x
* `pip2` will point to the pip associated with the brew-installed Python 2.7.x
* `pip3` will point to the pip associated with the brew-installed Python 3.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip3 points to Homebrew's Python 3.X's pip (if installed)

apjanke
apjanke approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@apjanke apjanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I like the new list format.

@MikeMcQuaid
Copy link
Member

Thanks for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit 877c911 into Homebrew:master Aug 1, 2017
@cclauss cclauss deleted the patch-2 branch August 3, 2017 09:42
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apjanke apjanke apjanke approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @MikeMcQuaid @apjanke