Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Tap in CaskLoader. #2965

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Detect Tap in CaskLoader. #2965

merged 1 commit into from
Aug 5, 2017

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 29, 2017 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Should make #2878 a bit easier.

@reitermarkus reitermarkus force-pushed the cask-tap branch 2 times, most recently from 8fe77ca to 03262e9 Compare July 29, 2017 15:21
@reitermarkus
Copy link
Member Author

cc @wendorf

@reitermarkus reitermarkus force-pushed the cask-tap branch 2 times, most recently from b78f9f2 to a559f0f Compare July 29, 2017 16:40
@reitermarkus reitermarkus requested a review from vitorgalvao July 29, 2017 18:15
@reitermarkus reitermarkus requested review from vitorgalvao and removed request for vitorgalvao August 4, 2017 14:31
@reitermarkus reitermarkus merged commit c26c920 into Homebrew:master Aug 5, 2017
@reitermarkus reitermarkus deleted the cask-tap branch August 5, 2017 14:54
@wendorf wendorf mentioned this pull request Aug 5, 2017
Merged
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorgalvao vitorgalvao Awaiting requested review from vitorgalvao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reitermarkus