Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Silence not notable on non-Homebrew taps #3277

Merged
merged 1 commit into from
Oct 8, 2017
Merged

audit: Silence not notable on non-Homebrew taps #3277

merged 1 commit into from
Oct 8, 2017

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Oct 6, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Silence the brew audit error message GitHub repository not notable for non-Homebrew taps.

MikeMcQuaid
MikeMcQuaid requested changes Oct 8, 2017
View reviewed changes
Library/Homebrew/dev-cmd/audit.rb Outdated
@@ -590,7 +590,8 @@ def audit_github_repository
return if metadata.nil?

problem "GitHub fork (not canonical repository)" if metadata["fork"]
if (metadata["forks_count"] < 20) && (metadata["subscribers_count"] < 20) &&
if user.casecmp("homebrew").zero? &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use formula&.tap&.core_tap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sjackman
audit: Silence not notable on non-Homebrew taps
53dd0e3 
Silence "GitHub repository not notable" on non-Homebrew taps.
@MikeMcQuaid MikeMcQuaid merged commit 56458f0 into Homebrew:master Oct 8, 2017
@MikeMcQuaid
Copy link
Member

Thanks again @sjackman!

@sjackman sjackman deleted the audit-notable branch October 9, 2017 16:16
@sjackman
Copy link
Contributor Author

sjackman commented Oct 9, 2017

Thanks for merging, Mike!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjackman @MikeMcQuaid