-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lines_cop: add ENV.universal_binary audit exemption for wine #3291
lines_cop: add ENV.universal_binary audit exemption for wine #3291
Conversation
cc @ilovezfs |
@@ -419,7 +419,22 @@ class Foo < Formula | |||
end | |||
end | |||
|
|||
it "with ENV.universal_binary" do | |||
it "with ENV.universal_binary exempted formula" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this into a proper sentence? Thanks. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only matching the one above it. So, inconsistency or proper sentences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally proper sentences for all, or specify
instead of it
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full fragment is: 'When auditing formula with ENV.universal_binary exempted formula'
any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I am referring to the line https://github.com/Homebrew/brew/pull/3291/files#diff-9349b511bf2b9967d30735fbb26db7b7R383)
@reitermarkus Is something like this what you had in mind? |
7aa72ef
to
e61114e
Compare
@reitermarkus gentle ping on this |
Something like this is what I had in mind. |
Since this has the context |
|
It should be possible to make it more intelligible than “when auditing formulae it with a build.universal? exemption”. Also, the context is pretty redundant, so this could actually be removed, and we'd just have |
e61114e
to
84f2db8
Compare
84f2db8
to
85fa79b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JCount!
brew tests
with your changes locally?add ENV.universal_binary audit exception for wine and corresponding test coverage