Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop 0.52.1 #3636

Merged
merged 2 commits into from
Jan 18, 2018
Merged

rubocop 0.52.1 #3636

merged 2 commits into from
Jan 18, 2018

Conversation

MikeMcQuaid
Copy link
Member

Let's see how this goes.

alyssais
alyssais reviewed Jan 7, 2018
View reviewed changes
Library/.rubocop.yml
@@ -123,6 +123,10 @@ Style/Documentation:
Style/Encoding:
Enabled: true

# disabled until we get the Metrics/LineLength down to 80.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that something we're actively working on/making progress in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 7, 2018
Closed
@MikeMcQuaid
Copy link
Member Author

@GauthamGoli any ideas on about the failures here?

@GauthamGoli
Copy link
Contributor

@MikeMcQuaid Yeah rubocop/rubocop#3558
We have to make autocorrect public in all the cops. Just remove private keyword in following cops

  • bottle_block_cop.rb
  • checksum_cop.rb
  • class_cop.rb
  • components_order_cop.rb
  • formula_desc_cop.rb
  • urls_cop.rb

@MikeMcQuaid
Copy link
Member Author

Thanks @GauthamGoli! Let's give it another shot.

@MikeMcQuaid MikeMcQuaid force-pushed the rubocop-bump branch 2 times, most recently from 41ad1f7 to 89e0406 Compare January 10, 2018 15:45
@MikeMcQuaid
Copy link
Member Author

CC @reitermarkus Can you add rubocop-cask support? Thanks!

@MikeMcQuaid MikeMcQuaid merged commit 1038423 into master Jan 18, 2018
@MikeMcQuaid MikeMcQuaid deleted the rubocop-bump branch January 18, 2018 15:16
@ilovezfs
Copy link
Contributor

This PR caused --display-cop-names to become the default. So there is now a redundant command line option in both brew audit and brew style, and there is no way to suppress the display of the fairly-useless-to-users cop names.

@ilovezfs
Copy link
Contributor

#3710

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alyssais alyssais alyssais left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeMcQuaid @GauthamGoli @ilovezfs @alyssais