Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask caveats dsl: add license #4172

Merged
merged 1 commit into from
May 15, 2018
Merged

cask caveats dsl: add license #4172

merged 1 commit into from
May 15, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented May 15, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This would allow us to have a consistent caveat with just a URL. Currently the caveats are all fairly similar but a bit inconsistent in their style.

@commitay commitay added the cask Homebrew Cask label May 15, 2018
@commitay commitay requested a review from a team May 15, 2018 07:54
@ghost ghost assigned commitay May 15, 2018
@ghost ghost added the in progress Maintainers are working on this label May 15, 2018
@@ -125,6 +125,13 @@ def eval_caveats(&block)
EOS
end

caveat :license do |web_page|
<<~EOS
Installing this Cask means you have AGREED to the license at:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other messages, use #{@cask} and remove :.

Installing #{@cask} means you have AGREED to the license at

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@commitay commitay merged commit 7b31a3d into Homebrew:master May 15, 2018
@ghost ghost removed the in progress Maintainers are working on this label May 15, 2018
@commitay commitay deleted the license-caveat branch May 15, 2018 10:09
@commitay commitay removed their assignment May 15, 2018
@lock lock bot added the outdated PR was locked due to age label Jun 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants