Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oldest_cpu: Bottling architecture of ARM is armv6 #4177

Merged
merged 1 commit into from
May 16, 2018

Conversation

sjackman
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR is required for brew portable-bottle ruby on 32-bit ARM.


armv6 is the oldest supported 32-bit ARM architecture
armv8-a is the oldest 64-bit ARM architecture.

See https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
and https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html

armv6 is the oldest supported 32-bit ARM architecture
armv8-a is the oldest 64-bit ARM architecture.

See https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
and https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html
@MikeMcQuaid MikeMcQuaid merged commit d8ccdd9 into Homebrew:master May 16, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @sjackman!

@sjackman sjackman deleted the oldest_cpu branch May 16, 2018 15:41
@sjackman
Copy link
Contributor Author

No worries at all. Thanks for the quick merge, Mike!

@lock lock bot added the outdated PR was locked due to age label Jun 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants