Alphabetize the brew outdated formula listing.

[dougal]

Sorts the output of brew outdated by Formula#<=>.

For me this significantly speeds up scanning the list to look for formula I consider critical to my work.

Includes updated test example.

Have you written new tests for your changes?

Not strictly speaking. I modified an existing test.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[reitermarkus]

Leave the first line as it was, and align .sort with .select.

[dougal]

Fixed in dougal/brew@c80842449

[reitermarkus]

Did you check if this specific case actually fails without sort?

[dougal]

Yes. Commenting out the sort line results in the following failure:

1) brew outdated quiet output prints outdated Formulae
     Failure/Error:
       expect { brew "outdated" }
         .to output("foo\ntestball\n").to_stdout
         .and not_to_output.to_stderr
         .and be_a_success
     
       expected block to output "foo\ntestball\n" to stdout, but output "testball\nfoo\n"

[ilovezfs]

I assume that's locally but not on CI.

[dougal]

Yes, locally.

CI should never fail as the tests were committed with the changes. I assume, unless I am misunderstanding something.

[ilovezfs]

I just mean that on CI, which is using HFS+, it probably always passes regardless of the sort, whereas locally it fails without the sort because you're using APFS. I'm not sure there's anything to be done about that really in terms of making the test actually test something on CI but I don't think we need to worry about sort not working.

[dougal]

Good insight on CI using HFS+, thanks.

I originally tried making the the test case more expansive, with different formulae inserted in different orders. I simplified it as I wasn't sure the expanded test case provided any value.

[reitermarkus]

I don't think we need to worry about sort not working.

Well, the test is not for sort itself, but for the fact that the output has to be sorted. Anyways, as long as it fails locally on APFS, it is good enough.

[reitermarkus]

Thank you for your first contribution to Homebrew, @dougal!