cask fetch and upgrade: print caveats #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vitorgalvao
previously approved these changes
May 29, 2018
| @@ -10,6 +10,7 @@ def initialize(*) | |||
|
|
|||
| def run | |||
| casks.each do |cask| | |||
| Installer.print_caveats | |||
There was a problem hiding this comment.
No. 😴
Also, I'll see if this can be tweaked to print only the relevant license caveat, showing all caveats isn't really needed.
There was a problem hiding this comment.
Changed my mind on only printing the license caveat for fetch, probably not worth it for what is basically an edge case.
|
Ping? |
vitorgalvao
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?cc @reitermarkus @vitorgalvao
fetchdoes not display caveats which may include a license caveat which has been accepted by fetching the cask.upgradedoes not display caveats which would mean a user would not see the caveat if it was added to the cask after it had been installed.