Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache_store: create HOMEBREW_CACHE when needed. #4369

Merged
merged 1 commit into from
Jun 21, 2018
Merged

cache_store: create HOMEBREW_CACHE when needed. #4369

merged 1 commit into from
Jun 21, 2018

Conversation

MikeMcQuaid
Copy link
Member

Fixes #4366.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ghost ghost assigned MikeMcQuaid Jun 21, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 21, 2018
ilovezfs
ilovezfs reviewed Jun 21, 2018
View reviewed changes
Library/Homebrew/cache_store.rb
@@ -62,7 +62,10 @@ def created?
# @return [DBM] db
def db
# DBM::WRCREAT: Creates the database if it does not already exist
@db ||= DBM.open(dbm_file_path, DATABASE_MODE, DBM::WRCREAT)
@db ||= begin
HOMEBREW_CACHE.mkpath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this fail on a permissions exception?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically but we assume it won't in enough other places I don't think it's worth special casing here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@MikeMcQuaid MikeMcQuaid merged commit b87fc8c into Homebrew:master Jun 21, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jun 21, 2018
@MikeMcQuaid MikeMcQuaid deleted the cache_store_mkpath branch June 21, 2018 13:57
@lock lock bot added the outdated PR was locked due to age label Jul 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees

@MikeMcQuaid MikeMcQuaid

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @ilovezfs