Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix VCS download strategies. #4418

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 4, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Use which to find the executables and move *path methods into the respective strategies.

@ghost ghost assigned reitermarkus Jul 4, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 4, 2018
@MikeMcQuaid
Copy link
Member

Nice work again!

@MikeMcQuaid MikeMcQuaid merged commit 08cbbfa into Homebrew:master Jul 4, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 4, 2018
@reitermarkus reitermarkus deleted the vcs-strategies branch July 5, 2018 10:12
@lock lock bot added the outdated PR was locked due to age label Aug 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants