Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle_block_cop: remove #4422

Merged
merged 1 commit into from
Jul 5, 2018
Merged

bottle_block_cop: remove #4422

merged 1 commit into from
Jul 5, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Jul 4, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Bottle revisions were deleted in #3896

@ghost ghost assigned commitay Jul 4, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 4, 2018
@MikeMcQuaid
Copy link
Member

Any problem with keeping this around for taps and for brew style --fix to be able to fix up old formulae?

@commitay
Copy link
Contributor Author

commitay commented Jul 4, 2018

Just tried it and it doesn't work.

Error: undefined method `revision' for #<BottleSpecification:0x007fe8641bdf60>
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/pypy.rb:10:in `block in <class:Pypy>'
/usr/local/Homebrew/Library/Homebrew/software_spec.rb:101:in `instance_eval'
/usr/local/Homebrew/Library/Homebrew/software_spec.rb:101:in `bottle'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2148:in `bottle'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/pypy.rb:8:in `<class:Pypy>'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/pypy.rb:1:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:26:in `module_eval'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:26:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:46:in `load_formula_from_path'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:101:in `load_file'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:92:in `klass'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:88:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:281:in `factory'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:461:in `find_with_priority'
/usr/local/Homebrew/Library/Homebrew/extend/ARGV.rb:48:in `block in formulae'
/usr/local/Homebrew/Library/Homebrew/extend/ARGV.rb:44:in `map'
/usr/local/Homebrew/Library/Homebrew/extend/ARGV.rb:44:in `formulae'
/usr/local/Homebrew/Library/Homebrew/cmd/style.rb:37:in `style'
/usr/local/Homebrew/Library/Homebrew/brew.rb:100:in `<main>'

@MikeMcQuaid
Copy link
Member

Cool fair enough! Thanks again.

@MikeMcQuaid MikeMcQuaid merged commit 9530af4 into Homebrew:master Jul 5, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 5, 2018
@commitay commitay deleted the bottle-cop branch July 5, 2018 07:55
@commitay commitay removed their assignment Jul 5, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants