Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: correctly handle build dep reqs. #4430

Merged
merged 1 commit into from
Jul 5, 2018
Merged

formula_installer: correctly handle build dep reqs. #4430

merged 1 commit into from
Jul 5, 2018

Conversation

MikeMcQuaid
Copy link
Member

When a build dependency has a requirement it should be ignored when checking for valid requirements. This requires calculating the dependencies for a formula again and checking them when calculating which requirements should be pruned.

Fixes #4373.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When a build dependency has a requirement it should be ignored when
checking for valid requirements. This requires calculating the
dependencies for a formula again and checking them when calculating
which requirements should be pruned.
@ghost ghost assigned MikeMcQuaid Jul 5, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 5, 2018
@MikeMcQuaid MikeMcQuaid merged commit 9fff177 into Homebrew:master Jul 5, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 5, 2018
@MikeMcQuaid MikeMcQuaid deleted the handle-build-dep-reqs branch July 5, 2018 20:36
@ilovezfs
Copy link
Contributor

ilovezfs commented Jul 6, 2018

Thanks!

@lock lock bot added the outdated PR was locked due to age label Aug 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants