Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: refactor, reorder and fix bugs. #4445

Merged
merged 1 commit into from
Jul 10, 2018
Merged

link: refactor, reorder and fix bugs. #4445

merged 1 commit into from
Jul 10, 2018

Conversation

MikeMcQuaid
Copy link
Member

The change in #4441 broke the handling of the elsifs due to the change in logic. As every block here has a next there's no need to do an elsif in here at all. Additionally, reorder the conditions in here so you get an appropriate message depending on what you're trying to do. Finally, tweak some of the messaging to remove things that are ignored and tell people correct commands to run to link things.

References #4441 (comment)

CC @ilovezfs @DomT4

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ghost ghost assigned MikeMcQuaid Jul 10, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 10, 2018
@MikeMcQuaid MikeMcQuaid requested a review from ilovezfs July 10, 2018 08:06
The change in #4441 broke the handling of the `elsif`s due to the
change in logic. As every block here has a `next` there's no need to do
an `elsif` in here at all. Additionally, reorder the conditions in here
so you get an appropriate message depending on what you're trying to do.
Finally, tweak some of the messaging to remove things that are ignored
and tell people correct commands to run to link things.
@ilovezfs ilovezfs merged commit a2b11f2 into Homebrew:master Jul 10, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 10, 2018
@ilovezfs
Copy link
Contributor

Thanks!

@DomT4
Copy link
Contributor

DomT4 commented Jul 10, 2018

Thanks Mike. Does indeed seem to resolve both the issues I was seeing locally.

@lock lock bot added the outdated PR was locked due to age label Aug 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2018
@MikeMcQuaid MikeMcQuaid deleted the rework-link branch November 28, 2018 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants