Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use JSON to marshal errors from children" #4723

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

MikeMcQuaid
Copy link
Member

Reverts #4717

Need to revert this because #4721 isn't ready to go yet. Will accept these changes again when they have more tests written to reproduce the issue @DomT4 described.

@ghost ghost assigned MikeMcQuaid Aug 18, 2018
@ghost ghost added the in progress Maintainers are working on this label Aug 18, 2018
@MikeMcQuaid MikeMcQuaid merged commit 9fc8265 into master Aug 18, 2018
@MikeMcQuaid MikeMcQuaid deleted the revert-4717-error-pipe branch August 18, 2018 07:48
@ghost ghost removed the in progress Maintainers are working on this label Aug 18, 2018
@lock lock bot added the outdated PR was locked due to age label Sep 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant