Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve formulae in brew cleanup. #4872

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Resolve formulae in brew cleanup. #4872

merged 1 commit into from
Sep 12, 2018

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolve formulae in brew cleanup.

Fixes #4856.

@ghost ghost assigned reitermarkus Sep 11, 2018
@ghost ghost added the in progress Maintainers are working on this label Sep 11, 2018
@reitermarkus
Copy link
Member Author

@xu-cheng, can you try this?

MikeMcQuaid
MikeMcQuaid approved these changes Sep 11, 2018
View reviewed changes
Library/Homebrew/extend/ARGV.rb
@@ -54,35 +54,7 @@ def formulae
def resolved_formulae
require "formula"
@resolved_formulae ||= (downcased_unique_named - casks).map do |name|
if name.include?("/") || File.exist?(name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring 👍

@xu-cheng
Copy link
Member

@xu-cheng, can you try this?

Yes, it fixes the problem for me. Thanks for the fix.

@reitermarkus reitermarkus merged commit 375088c into Homebrew:master Sep 12, 2018
@reitermarkus reitermarkus deleted the cleanup-resolve-formulae branch September 12, 2018 10:48
@ghost ghost removed the in progress Maintainers are working on this label Sep 12, 2018
@lock lock bot added the outdated PR was locked due to age label Oct 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

@reitermarkus reitermarkus

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @xu-cheng @MikeMcQuaid