Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remaining curl respect HOMEBREW_CURLRC #4900

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Conversation

lembacon
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Make the curl invocation in cmd/update and utils/analytics both respect the HOMEBREW_CURLRC environment variable, as utils/curl already does so, otherwise the annoying warning Failed to set filetime on outfile: Operation not permitted will pop up every time brew update running.

@ghost ghost assigned lembacon Sep 14, 2018
@ghost ghost added the in progress Maintainers are working on this label Sep 14, 2018
@MikeMcQuaid
Copy link
Member

Looks good, thanks @lembacon! Merge when ready.

@lembacon lembacon merged commit 76b41ba into Homebrew:master Sep 14, 2018
@ghost ghost removed the in progress Maintainers are working on this label Sep 14, 2018
@lembacon lembacon deleted the curlrc branch September 14, 2018 13:59
@lock lock bot added the outdated PR was locked due to age label Oct 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants