Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveSupport Object#blank? and #present? #4902

Merged
merged 2 commits into from
Sep 16, 2018
Merged

Use ActiveSupport Object#blank? and #present? #4902

merged 2 commits into from
Sep 16, 2018

Conversation

MikeMcQuaid
Copy link
Member

This partially adds ActiveSupport (and Concurrent Ruby, a dependency) gems.

This adds some slight overhead (~10%) to loading global.rb but I think it's
probably worth it for us to be able to write better code while relying on
well-tested, widely used and understood libraries.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ghost ghost assigned MikeMcQuaid Sep 14, 2018
@ghost ghost added the in progress Maintainers are working on this label Sep 14, 2018
@reitermarkus reitermarkus merged commit dfb6ada into Homebrew:master Sep 16, 2018
@ghost ghost removed the in progress Maintainers are working on this label Sep 16, 2018
@MikeMcQuaid MikeMcQuaid deleted the active-support-blank branch September 16, 2018 18:23
@lock lock bot added the outdated PR was locked due to age label Oct 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants