Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bin/brew: Pass CIRCLECI environment variable" #5404

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

sjackman
Copy link
Member

This reverts commit 64a9543.

Use HOMEBREW_CIRCLECI rather than CIRCLECI.
See PR #5402
and PR Homebrew/homebrew-test-bot#217

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This reverts commit 64a9543.

Use HOMEBREW_CIRCLECI rather than CIRCLECI.
See Homebrew#5402
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sjackman 🙇

@sjackman sjackman merged commit e5df649 into Homebrew:master Dec 14, 2018
@sjackman sjackman deleted the circleci branch December 14, 2018 17:32
@lock lock bot added the outdated PR was locked due to age label Jan 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants