Bugfix: Calculate actual delta in usage #5683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?I read the guidelines three times, I do not understand it. Most of it seems to apply to formula changes only? Maybe needs better headline/section structure.
Changes:
This fixes a bug, that when you do a cleanup and the cleanup fails for a path (e.g. no permissions to remove path), the size of that path would still be added to the cleanup estimate. By calculating the delta of disk usage before and after the removal, we get a clear picture of how much disk space was saved.