Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceptions.rb: move alternative solution to a new line #5705

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

maxim-belkin
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The message that Homebrew spits out when build tools are not available is not formatted appropriately:

Error: The following flag:
  --build-from-source
requires building tools, but none are installed.
Install Clang or brew install gccAlternatively, remove the flag to attempt bottle installation.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:79:in `prevent_build_flags'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:119:in `install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:105:in `<main>'

This PR adds a new line before Alternatively, ....

@MikeMcQuaid
Copy link
Member

@maxim-belkin Just remove both the chomps?

@maxim-belkin
Copy link
Contributor Author

That would work too

remove `chomp!` from method 'initialize' in class 'BuildFlagsError'
@MikeMcQuaid MikeMcQuaid merged commit 8c3a46a into Homebrew:master Feb 11, 2019
@MikeMcQuaid
Copy link
Member

Thanks @maxim-belkin!

@lock lock bot added the outdated PR was locked due to age label Mar 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 13, 2019
@maxim-belkin maxim-belkin deleted the build-tools-text-fix branch July 2, 2019 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants