Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_installer: handle attempts to load invalid casks #5710

Merged

Conversation

mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Feb 11, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Certain casks in the main cask repository may be invalid, for whatever reason. Without handling this exception, the user will get a cask-related exception while the formula of the same name is installed, and their installation will abort half-completed.

For example, the fish cask is currently broken and attempting to brew cask info fish will return an error. This also leads to attempts to install the fish formula to fail like this:

==> Upgrading fish
==> Downloading https://homebrew.bintray.com/bottles/fish-3.0.1.mojave.bottle.tar.gz
######################################################################## 100.0%
==> Pouring fish-3.0.1.mojave.bottle.tar.gz
Error: Cask 'fish' definition is invalid: invalid 'depends_on macos' value: ":snow_leopard"

Fixes #5709.

Certain casks in the main cask repository may be invalid, for whatever
reason. Without handling this exception, the user will get a cask-related
exception while the formula of the same name is installed, and their
installation will abort half-completed.

Fixes Homebrew#5709.
@mistydemeo mistydemeo merged commit 4550f70 into Homebrew:master Feb 11, 2019
@mistydemeo mistydemeo deleted the formula_installer_fix_invalid_cask branch February 11, 2019 23:30
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Feb 12, 2019

Nice catch, thanks @mistydemeo!

@lock lock bot added the outdated PR was locked due to age label Mar 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants