Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: allow Docker to run as root. #5733

Merged
merged 2 commits into from
Feb 15, 2019
Merged

brew.sh: allow Docker to run as root. #5733

merged 2 commits into from
Feb 15, 2019

Conversation

MikeMcQuaid
Copy link
Member

Now I've used Docker more I accept this is more commonplace in that world.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid requested review from sjackman and a team February 14, 2019 10:45
@sjackman sjackman requested a review from iMichka February 14, 2019 17:47
@MikeMcQuaid
Copy link
Member Author

MikeMcQuaid commented Feb 14, 2019

@sjackman Worth updating any of this with this in mind: https://github.com/Homebrew/brew/blob/master/Dockerfile#L35-L39?

@sjackman
Copy link
Contributor

Absolutely! One concern is that there's likely Dockerfiles in the wild that inherit from this Docker image and expect there to be a linuxbrew user, and expect to be running as that user. I'm certain that I have a few myself. I'd suggest we still create the Linuxbrew user, but make the default user root. That way, fixing a downstream image just means adding USER linuxbrew.

@MikeMcQuaid
Copy link
Member Author

I'd suggest we still create the Linuxbrew user, but make the default user root. That way, fixing a downstream image just means adding USER linuxbrew.

@sjackman Seems like a good idea 👍

@MikeMcQuaid MikeMcQuaid changed the title brew.sh: all Docker to run as root. brew.sh: allow Docker to run as root. Feb 15, 2019
This defaults to `root` but we still want to keep a Linuxbrew user on
the system.
@MikeMcQuaid MikeMcQuaid dismissed sjackman’s stale review February 15, 2019 10:10

Changes addressed.

@MikeMcQuaid MikeMcQuaid removed the request for review from iMichka February 15, 2019 10:11
@MikeMcQuaid MikeMcQuaid merged commit 2ca56f6 into Homebrew:master Feb 15, 2019
@MikeMcQuaid MikeMcQuaid deleted the docker-root branch February 15, 2019 10:55
@lock lock bot added the outdated PR was locked due to age label Mar 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants