-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Disable tests that require being non-root #5757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Feb 16, 2019
MikeMcQuaid
reviewed
Feb 16, 2019
MikeMcQuaid
approved these changes
Feb 16, 2019
I'll merge this PR after CI is 💚. Hopefully that fixes the failed build on Docker Hub. |
Set the environment variable USER=root which is required by brew tests --only=utils/user Fix these tests: rspec ./test/diagnostic_checks_spec.rb:26 # Homebrew::Diagnostic::Checks #check_access_directories rspec ./test/pathname_spec.rb:120 # Pathname#ensure_writable makes a file writable and restores permissions rspec ./test/utils/user_spec.rb:22 # User#gui? when the current user is in a console session gui? should equal true rspec ./test/utils/user_spec.rb:6 # User should eq nil
iMichka
approved these changes
Feb 16, 2019
Thanks @sjackman |
Thanks for merging, Michka! |
Docker Hub build failed with…
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the environment variable USER=root which is required by
brew tests --only=utils/user
Fix these tests:
brew style
with your changes locally?brew tests
with your changes locally?