Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CLI arg/env var prioritization + corresponding tests #5805

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

BenMusch
Copy link
Contributor

@BenMusch BenMusch commented Feb 25, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes bug in #5738
Fixes #5736

Explanation of what happened:

  • When I changed the names of the :env_var value to :env, I left one unchanged
  • The tests were passingly misleadingly because the stubbing order made it so that all env vars were actually ignored (and one of my tests was testing the non-env-var behavior due to my mistake in the test)

Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the updated test fails without the corresponding fix.

@MikeMcQuaid
Copy link
Member

Thanks again @BenMusch!

@MikeMcQuaid MikeMcQuaid merged commit d1f7559 into Homebrew:master Feb 26, 2019
@lock lock bot added the outdated PR was locked due to age label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants