Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wording #5838

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Improve wording #5838

merged 3 commits into from
Mar 6, 2019

Conversation

JakeConnors376W
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid reviewed Mar 5, 2019
View reviewed changes
docs/Installation.md Outdated
@@ -1,7 +1,6 @@
# Installation

The supported and best way to install Homebrew is on the
[homepage](https://brew.sh).
Instructions for installing Homebrew are on the [homepage](https://brew.sh).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the word "supported" here somewhere? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the current wording work? If not, how about "Instructions for a supported install of Homebrew are on the homepage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter sounds great ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid updated

@MikeMcQuaid
Copy link
Member

Great work!
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @JakeConnors376W!

@MikeMcQuaid MikeMcQuaid merged commit a188678 into Homebrew:master Mar 6, 2019
@lock lock bot added the outdated PR was locked due to age label Apr 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeConnors376W @MikeMcQuaid