cleanup: fix for formula/cask name collision #5843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?When a formula and cask share the same name, a download can be incorrectly considered stale. This is the case for the name
docker
:This is because the download for the cask
docker
(/Users/chase/Library/Caches/Homebrew/Cask/docker--2.0.0.3-ce-mac81,31259.dmg
) is considered a stale download for the formuladocker
.The fix is to call either
stale_formula?
orstale_cask?
on the download based on the containing directory, but not both. Also, a check on the containing directory instale_cask?
is no longer necessary.