Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions/zsh: Hide *instal from all commands #5851

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

okdana
Copy link
Contributor

@okdana okdana commented Mar 7, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

After my other completion PR was merged, someone contacted me to ask if i could help with this Discourse post. The user is bothered by the fact that the zsh completion function offers one-letter-short aliases like instal and uninstal. I agree that they aren't helpful, as they produce confusing-looking output and force unnecessary disambiguation when the user enters (e.g.) unintab.

These aliases were already hidden in the bash completion function in PR #3052. This change just does the equivalent for the zsh function.

Note for anyone testing this: If you have caching enabled, you may need to delete the cache files (under ~/.zcompcache by default) to see the change right away.

Aliases like instal and uninstal are unhelpful and noisy; don't offer them

See also PR Homebrew#3052
@jonchang jonchang merged commit db3a42e into Homebrew:master Mar 8, 2019
@jonchang
Copy link
Contributor

jonchang commented Mar 8, 2019

Thanks for the help @okdana!

@lock lock bot added the outdated PR was locked due to age label Apr 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants