Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class name for brew extract #5882

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

kiendang
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix an oversight in #5868. When run

brew extract --version=1.10.5 kubernetes-cli custom/formulae

class name for [email protected] is KubernetescliAT1105 instead of KubernetesCliAT1105 as expected.

So sorry for not testing this out properly earlier. Wanted to add a test case for this but looks like can't setup_test_formula a formula name with hyphen.

@MikeMcQuaid MikeMcQuaid merged commit c510b64 into Homebrew:master Mar 15, 2019
@MikeMcQuaid
Copy link
Member

No worries, thanks for the quick fix and thanks again for contributing to Homebrew!

@kiendang kiendang deleted the extract-class-name branch March 15, 2019 08:41
@lock lock bot added the outdated PR was locked due to age label Apr 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants