Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-Maintainer-Checklist: there are multiple places we list maintainers #6178

Merged
merged 1 commit into from
May 27, 2019
Merged

New-Maintainer-Checklist: there are multiple places we list maintainers #6178

merged 1 commit into from
May 27, 2019

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented May 27, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • I raised a PR for adding myself to the README. CI failed because the
    README had changed without the man pages changing too. Then I had to
    amend my "hello!" commit, which was slightly embarrassing.
  • Document that there are multiple places, and link to an example, so
    that the next new people have it easier.

@issyl0
New-Maintainer-Checklist: there are multiple places we list maintainers
dd92fdf 
- I raised a PR for adding myself to the README. CI failed because the
  README had changed without the man pages changing too. Then I had to
  amend my "hello!" commit which was slightly embarrassing.
- Document that there are multiple places, and suggest `brew man` to
  generate man pages, so that the next people have it easier.
@issyl0 issyl0 force-pushed the new_maintainer_docs_more_places_to_add_people branch from 8d31b68 to dd92fdf Compare May 27, 2019 13:37
@MikeMcQuaid MikeMcQuaid merged commit 06544dc into Homebrew:master May 27, 2019
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @MikeMcQuaid