Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Maintainer Checklist: add "real" name, meetup suggestion. #6185

Merged
merged 2 commits into from
May 30, 2019

Conversation

MikeMcQuaid
Copy link
Member

We've had problems in the past with Homebrew maintainers being unwilling to disclose their identity or meet other maintainers so here are some very light-touch suggestions to address this in future.

These ideas were run past the PLC and agreed there but I still welcome input from @Homebrew/maintainers.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@@ -79,6 +79,8 @@ If they are elected to the Homebrew's [Project Leadership Committee](https://doc

If there are problems, ask them to step down as a maintainer and revoke their access to all of the above.

In interests of loosely verifying maintainer identity and building camaraderie, if you find yourself in the same town (e.g living, visiting or at a conference) as another Homebrew maintainer you should make the effort to meet up. If you do so, you can expense your meal (within SFC policies). This is a more relaxed version of e.g. the Debian system to meet in person to sign keys with a legal ID verification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, we’re talking about expensing the meals for both parties? This is quite a fun idea!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! That's what we've done at GitHub also as a gentle nudge and, with a peek at Homebrew's finances, we have enough funds to do that if people aren't being silly about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alebcay Durham Homebrew meetup? 😀

Copy link
Member

@alebcay alebcay Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachauten Having neglected my GitHub notifications for about five months 😅, I've missed this, but if you're still up for it, let's meet up sometime!

Copy link
Contributor

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be helpful to link the SFC reimbursement policy but otherwise 👍

MikeMcQuaid and others added 2 commits May 30, 2019 09:18
We've had problems in the past with Homebrew maintainers being unwilling to disclose their identity or meet other maintainers so here are some very light-touch suggestions to address this in future.

These ideas were run past the PLC and agreed there but I still welcome input from maintainers.
@MikeMcQuaid MikeMcQuaid force-pushed the new-maintainer-checklist-tweaks branch from 00f6360 to 42c8861 Compare May 30, 2019 08:18
@MikeMcQuaid MikeMcQuaid merged commit 33660d5 into master May 30, 2019
@MikeMcQuaid
Copy link
Member Author

Thanks for review and comments all!

@MikeMcQuaid MikeMcQuaid deleted the new-maintainer-checklist-tweaks branch May 30, 2019 08:40
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.