Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redownload “latest” casks unnecessarily. #6195

Merged
merged 2 commits into from
May 31, 2019

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Don't re-download unversioned casks if the web server returns a timestamp.

@reitermarkus reitermarkus requested a review from a team May 31, 2019 18:44
@reitermarkus reitermarkus force-pushed the latest-cask-downloads branch from c5af33f to 17f6d19 Compare May 31, 2019 18:50
@reitermarkus reitermarkus merged commit eec2928 into Homebrew:master May 31, 2019
@reitermarkus reitermarkus deleted the latest-cask-downloads branch May 31, 2019 20:07
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant