Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't URL-encode cookies. #6196

Merged
merged 1 commit into from
May 31, 2019
Merged

Don't URL-encode cookies. #6196

merged 1 commit into from
May 31, 2019

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #6148.

@reitermarkus reitermarkus requested a review from a team May 31, 2019 20:05
@reitermarkus reitermarkus merged commit f6c303c into Homebrew:master May 31, 2019
@reitermarkus reitermarkus deleted the cookies branch May 31, 2019 22:14
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorgalvao vitorgalvao vitorgalvao approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Cask Formula with Cookie encoding requirements fails
2 participants
@reitermarkus @vitorgalvao