Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottles: allow skipping or_later tags #6212

Merged

Conversation

mistydemeo
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a developer-only feature, so it's gated via HOMEBREW_DEVELOPER.

This is intended to enable testing of macOS 10.15; users building software manually to test compatibility of early betas need to be able to build software from source instead of via pouring 10.14 bottles. This isn't intended to be a general-purpose HOMEBREW_BUILD_FROM_SOURCE replacement, and has no effect on released versions of macOS.

I've rewritten the existing "uses older tags when needed" test in order to make it look more like my new test, for clarity.

@mistydemeo mistydemeo force-pushed the allow_skipping_or_later_bottles branch from c644d03 to 302992e Compare June 6, 2019 15:02
@MikeMcQuaid
Copy link
Member

Thanks again @mistydemeo!

@mistydemeo mistydemeo force-pushed the allow_skipping_or_later_bottles branch 2 times, most recently from 9dbebc6 to 5ab34ab Compare June 6, 2019 17:13
This is a developer-only feature, so it's gated via `HOMEBREW_DEVELOPER`.
This is intended to enable testing of macOS 10.15; users building software
manually to test compatibility of early betas need to be able to build
software from source instead of via pouring 10.14 bottles. This isn't
intended to be a general-purpose `HOMEBREW_BUILD_FROM_SOURCE` replacement,
and has no effect on released versions of macOS.
@mistydemeo mistydemeo merged commit 1475554 into Homebrew:master Jun 6, 2019
@mistydemeo mistydemeo deleted the allow_skipping_or_later_bottles branch June 6, 2019 19:07
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants