Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask_reason will suggest brew cask uninstall #6321

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

zachauten
Copy link
Contributor

@zachauten zachauten commented Jul 24, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Closes #6260

@zachauten
Copy link
Contributor Author

Still a work in progress, just opening the pull request to get some suggestions. @MikeMcQuaid I know you mentioned not wanting to use Homebrew.args in #6247, would you mind explaining the reasoning behind that?

I'm using it here temporarily out of convenience because this PR introduces a second conditional that depends on the command brew was called with (brew uninstall uses Cask::Caskroom.casks while brew install & brew info use Cask::CaskLoader.load)

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid I know you mentioned not wanting to use Homebrew.args in #6247, would you mind explaining the reasoning behind that?

It's global state that's better passed explicitly to the class rather than handled implicitly like this. That will make it easier to test and refactor in future.

@zachauten zachauten force-pushed the uninstall-suggestions branch 3 times, most recently from 56f80db to 673de62 Compare July 31, 2019 04:29
@zachauten zachauten force-pushed the uninstall-suggestions branch from 673de62 to ecc7b9e Compare July 31, 2019 04:32
@zachauten zachauten changed the title cask_reason will suggest a command cask_reason will suggest brew cask uninstall Jul 31, 2019
@zachauten zachauten marked this pull request as ready for review July 31, 2019 04:38
@zachauten zachauten requested a review from MikeMcQuaid August 2, 2019 01:53
@MikeMcQuaid
Copy link
Member

Looks great, thanks again @zachauten!

@MikeMcQuaid MikeMcQuaid merged commit de72a23 into Homebrew:master Aug 2, 2019
@zachauten zachauten deleted the uninstall-suggestions branch August 2, 2019 06:29
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cask uninstall fallback/suggestions
2 participants