Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: handle development git version strings #6352

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Aug 7, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This adds handling of longer git version strings for development builds by splitting the string on dots with read and discarding the fourth dot and anything following. It also accounts for when the build version number is three digits. These example version numbers will now be properly parsed.

This is an alternative to #6319.

Closes #6319

if [[ $(numeric "${system_git_version_output##* }") -lt $(numeric "$HOMEBREW_MINIMUM_GIT_VERSION") ]]
# $extra is intentionally discarded.
# shellcheck disable=SC2034
IFS=. read -r major minor micro build extra <<< "${system_git_version_output##* }"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will just set IFS for this single line, right?

@MikeMcQuaid
Copy link
Member

Nice work again @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit 34f4853 into Homebrew:master Aug 8, 2019
@EricFromCanada EricFromCanada deleted the git-version-parsing branch August 8, 2019 12:27
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants