Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cask-eid tap from automerge #6355

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Remove cask-eid tap from automerge #6355

merged 1 commit into from
Aug 11, 2019

Conversation

jerr0328
Copy link
Contributor

Since the homebrew-cask-eid tap is no longer in use, it should be removed from the automerge command as well. This seems to be the only reference to it in the codebase.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Since the homebrew-cask-eid tap is no longer in use, it should be removed from the command as well.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerr0328!

@MikeMcQuaid MikeMcQuaid merged commit 7ffc14a into Homebrew:master Aug 11, 2019
@jerr0328 jerr0328 deleted the patch-1 branch August 11, 2019 22:02
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants