Expose uses_from_macos list in formula API
#6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricFromCanada
force-pushed
the
uses_from_macos-json
branch
from
ac427d6 to
7419bb4
Compare
MikeMcQuaid
reviewed
Sep 18, 2019
EricFromCanada
force-pushed
the
uses_from_macos-json
branch
2 times, most recently
from
c1fbdd8 to
13255ec
Compare
EricFromCanada
changed the title
uses_from_macos in formula API as "macos_dependencies"uses_from_macos list in formula API
EricFromCanada
force-pushed
the
uses_from_macos-json
branch
from
13255ec to
b6efd65
Compare
MikeMcQuaid
reviewed
Sep 19, 2019
| @@ -4,22 +4,28 @@ class SoftwareSpec | |||
| undef uses_from_macos | |||
|
|
|||
| def uses_from_macos(deps, **args) | |||
| @macos_deps ||= [] | |||
There was a problem hiding this comment.
Thoughts on just uses_from_macos? I think the use of deps here is a bit misleading because at this stage this aren't actually dependencies.
EricFromCanada
force-pushed
the
uses_from_macos-json
branch
from
b6efd65 to
975c4e4
Compare
EricFromCanada
force-pushed
the
uses_from_macos-json
branch
from
975c4e4 to
f6ef26a
Compare
MikeMcQuaid
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Sorry, missed the updates here! Give me a shout if you force-push and I don't acknowledge it. Thanks again @EricFromCanada!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?As suggested in #6162.
This also fixes some inverted logic in how
before:andafter:are handled, as mentioned earlier, i.e.add_mac_dependency?needs to return false (causing the dependency version shipped with macOS to be used) if the current OS version is greater than or equal to theafter:value, or less than thebefore:value.