Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args #6857

Merged
merged 5 commits into from
Jan 2, 2020
Merged

ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args #6857

merged 5 commits into from
Jan 2, 2020

Conversation

GauthamGoli
Copy link
Contributor

@GauthamGoli GauthamGoli commented Dec 19, 2019 •
edited by MikeMcQuaid
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

@GauthamGoli
Copy link
Contributor Author

GauthamGoli commented Jan 2, 2020 •
edited
Loading

@MikeMcQuaid I am not able to reproduce the failing test locally, I am instead getting a segmentation error for that particular test. Any pointers/ideas on how to debug it ?

@MikeMcQuaid
Copy link
Member

@GauthamGoli What macOS version are you on?

@MikeMcQuaid
Copy link
Member

(this is an issue that seems to happen sometimes with the portable ruby only when running brew tests).

@GauthamGoli
Copy link
Contributor Author

I am on macOS High Sierra 10.13.6

MikeMcQuaid
MikeMcQuaid approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauthamGoli Have rebased on origin/master, fixed the relevant tests and addressed some comments I would have left. Good to 🚢 when you are!

@MikeMcQuaid MikeMcQuaid merged commit c0b9167 into Homebrew:master Jan 2, 2020
@MikeMcQuaid
Copy link
Member

Actually, let's just 🚢. Thanks again @GauthamGoli!

@goibon goibon mentioned this pull request Jan 19, 2020
Closed
@lock lock bot added the outdated PR was locked due to age label Feb 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauthamGoli @MikeMcQuaid