Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV/std: port superenv SDK changes #7426

Merged
merged 1 commit into from
Apr 24, 2020
Merged

ENV/std: port superenv SDK changes #7426

merged 1 commit into from
Apr 24, 2020

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 23, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Now that the superenv SDK changes have stabilised, let's incorporate those changes into the stdenv.

This, along with the minor change to test.rb, means that the test environment is now consistent with the build environment in terms of SDK selection. This fixes a couple of errors caused by that inconsistency.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some style suggestions. Some may be wrong because I find unless ... || hard to parse but: I'm sure you get the idea.

Library/Homebrew/extend/os/mac/extend/ENV/std.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/mac/extend/ENV/std.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/mac/extend/ENV/std.rb Outdated Show resolved Hide resolved
@Bo98 Bo98 merged commit d5ab653 into Homebrew:master Apr 24, 2020
@Bo98 Bo98 deleted the std-sdk branch April 24, 2020 19:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants