audit: make audit_revision_and_version_scheme faster.

[MikeMcQuaid]

This is really, really slow at the moment for a few reasons:

• it goes through the list of revisions twice
• it checks many more revisions than it needs to
• it checks devel even when that's never used in homebrew/core

Even after these improvements it's still by far the slowest audit so am also making it a strict or new-formula audit.

before:

audit_postgresql:                   0.0000 sec
audit_gitlab_repository:            0.0000 sec
audit_bottle_spec:                  0.0000 sec
audit_github_repository:            0.0000 sec
audit_versioned_keg_only:           0.0000 sec
audit_style:                        0.0000 sec
audit_bottle_disabled:              0.0000 sec
audit_conflicts:                    0.0000 sec
audit_bitbucket_repository:         0.0000 sec
audit_homepage:                     0.0000 sec
audit_specs:                        0.0002 sec
audit_reverse_migration:            0.0004 sec
audit_prefix_has_contents:          0.0011 sec
audit_lines:                        0.0011 sec
audit_formula_name:                 0.0026 sec
audit_file:                         0.0068 sec
audit_deps:                         0.0125 sec
audit_text:                         0.0207 sec
audit_installed:                    0.1784 sec
audit_revision_and_version_scheme:  32.1020 sec

after:

audit_postgresql:                   0.0000 sec
audit_bottle_spec:                  0.0000 sec
audit_github_repository:            0.0000 sec
audit_versioned_keg_only:           0.0000 sec
audit_gitlab_repository:            0.0000 sec
audit_homepage:                     0.0000 sec
audit_bottle_disabled:              0.0000 sec
audit_conflicts:                    0.0000 sec
audit_style:                        0.0000 sec
audit_bitbucket_repository:         0.0000 sec
audit_specs:                        0.0002 sec
audit_reverse_migration:            0.0003 sec
audit_prefix_has_contents:          0.0010 sec
audit_lines:                        0.0011 sec
audit_formula_name:                 0.0029 sec
audit_deps:                         0.0038 sec
audit_file:                         0.0067 sec
audit_text:                         0.0227 sec
audit_installed:                    0.1935 sec
audit_revision_and_version_scheme:  12.6690 sec

I'm not confident this works as expected so would appreciate detailed review.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[Bo98]

I certainly understand what this code is doing much better than whatever it was doing before.

[MikeMcQuaid]

@Bo98 Have added a --git (PR to add it to test-bot incoming). Let me know what you think. I'm aware some tests are failing.

[Bo98]

Makes sense