Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: deprecate devel blocks. #7688

Merged
merged 1 commit into from
Jun 5, 2020
Merged

formula: deprecate devel blocks. #7688

merged 1 commit into from
Jun 5, 2020

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jun 4, 2020 •
edited
Loading

As we haven't released 2.3.1 I think we can get away with sneaking this in. I'm also prepared to back this out if it's too widely used and there's too much backlash.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
formula: deprecate devel blocks.
22857b5 
As we haven't released 2.3.1 I think we can get away with sneaking this
in. I'm also prepared to back this out if it's too widely used and
there's too much backlash.
@MikeMcQuaid MikeMcQuaid merged commit 6409fe7 into Homebrew:master Jun 5, 2020
@MikeMcQuaid MikeMcQuaid deleted the deprecate-devel branch June 5, 2020 08:43
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jun 10, 2020
Merged
6 tasks
marsmensch added a commit to marsmensch/homebrew-devtools that referenced this pull request Jun 16, 2020
@marsmensch
Remove deprecated devel blocks from formula, see Homebrew/brew#7688
c727b74
@marsmensch marsmensch mentioned this pull request Jun 16, 2020
Closed
@Gasol Gasol mentioned this pull request Sep 24, 2020
Closed
Gasol added a commit to Gasol/homebrew-formulae that referenced this pull request Sep 24, 2020
@Gasol
Use head blocks instead of devel blocks
be9eb8e 
Because devel blocks has been deprecated since Homebrew 2.4.0.
Please see Homebrew/brew#7688 for details.

Fix #2
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @BrewTestBot