Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve errors reported by Sorbet #7785

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Resolve errors reported by Sorbet #7785

merged 3 commits into from
Jun 22, 2020

Conversation

vidusheeamoli
Copy link
Contributor

@vidusheeamoli vidusheeamoli commented Jun 22, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Error 4015, was caused because Sorbet could not identify MacOS as a class/module. This was because MacOS was dynamically defined in both os/linux.rb:30 and os/mac.rb:15.

I tried to replicate the module nesting in os/linux.rb file as per my understanding on sorbet.run :

@vidusheeamoli
Check in new definitions to Sorbet
53858e2 
New files were created after the last Sorbet update.
New definitions were added to hidden-definitions and rbi/todo was
updated
@vidusheeamoli
srb: resolve error 4015. 25 errors => 18 errors
d6e5874
@vidusheeamoli
srb: resolve error 4012. 18 errors => 13 errors
a919ba9
MikeMcQuaid
MikeMcQuaid approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work again @vidusheeamoli!

@MikeMcQuaid MikeMcQuaid merged commit 66f7818 into Homebrew:master Jun 22, 2020
@vidusheeamoli vidusheeamoli deleted the resolve-srb-errors branch June 22, 2020 17:20
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vidusheeamoli @MikeMcQuaid @issyl0 @BrewTestBot