Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Why haven’t you pulled my pull request?' change #7790

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

peterlewis
Copy link
Contributor

I propose changing 'Why haven’t you pulled my pull request?' to 'Why haven’t you merged my pull request?' as, unless I'm missing a trick, this wording would fit more appropriately with what the question trying to ask?

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I propose changing 'Why haven’t you pulled my pull request?' to 'Why haven’t you merged my pull request?' as, unless I'm missing a trick, this wording would fit more appropriately with what the question trying to ask?
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, this uses more common wording. Thanks, @peterlewis!

@issyl0 issyl0 merged commit ec5952d into Homebrew:master Jun 22, 2020
@peterlewis
Copy link
Contributor Author

Lovely stuff, thanks for reviewing/merging this so quickly, @issyl0! A part of me wanted you to take a while over it, so I could say "Why haven't you merged my pull request?" :)

@issyl0
Copy link
Member

issyl0 commented Jun 22, 2020

Haha, clever! 😉

@peterlewis peterlewis deleted the patch-1 branch June 22, 2020 21:32
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants